From 286fcc67d2bbe648810d6c0a7a9c3393296941b0 Mon Sep 17 00:00:00 2001
From: Fabian Montero <fabian@posixlycorrect.com>
Date: Thu, 28 Aug 2025 16:25:44 -0600
Subject: [PATCH] xdg: fix typo in settings which prevented default apps from
 being set

---
 home/modules/firefox.nix     | 44 ++++++++++++------------------------
 home/modules/gui/default.nix |  4 ++--
 2 files changed, 17 insertions(+), 31 deletions(-)

diff --git a/home/modules/firefox.nix b/home/modules/firefox.nix
index 93feb80..b81e32b 100644
--- a/home/modules/firefox.nix
+++ b/home/modules/firefox.nix
@@ -9,37 +9,23 @@ with lib; let
 in {
   options.local.apps.firefox = {
     enable = mkEnableOption "firefox settings";
-
-    makeDefaultBrowser = mkOption {
-      type = types.bool;
-      default = true;
-      description = ''
-        Take a guess
-      '';
-    };
   };
 
-  config = mkIf cfg.enable (mkMerge [
-    {
-      programs.firefox.enable = true;
-    }
-
-    (mkIf cfg.makeDefaultBrowser {
-      xdg = {
-        mimeApps = {
-          enable = true;
-          defaultApplications = {
-            "text/html" = ["firefox"];
-            "text/uri-list" = ["firefox"];
-            "x-scheme-handler/http" = ["firefox"];
-            "x-scheme-handler/https" = ["firefox"];
-            "x-scheme-handler/about" = ["firefox"];
-            "x-scheme-handler/unknown" = ["firefox"];
-          };
+  config = mkIf cfg.enable {
+    programs.firefox.enable = true;
+    xdg = {
+      mimeApps = {
+        enable = true;
+        defaultApplications = {
+          "text/html" = ["firefox.desktop"];
+          "text/uri-list" = ["firefox.desktop"];
+          "x-scheme-handler/http" = ["firefox.desktop"];
+          "x-scheme-handler/https" = ["firefox.desktop"];
+          "x-scheme-handler/about" = ["firefox.desktop"];
+          "x-scheme-handler/unknown" = ["firefox.desktop"];
         };
       };
-
-      home.sessionVariables.DEFAULT_BROWSER = "${lib.getExe pkgs.firefox}";
-    })
-  ]);
+    };
+    home.sessionVariables.DEFAULT_BROWSER = "${lib.getExe pkgs.firefox}";
+  };
 }
diff --git a/home/modules/gui/default.nix b/home/modules/gui/default.nix
index 110a835..1a72ed9 100644
--- a/home/modules/gui/default.nix
+++ b/home/modules/gui/default.nix
@@ -61,8 +61,8 @@ in {
       mimeApps = {
         enable = true;
         defaultApplications = {
-          "application/pdf" = with pkgs; ["qpdfview"];
-          "x-scheme-handler/file" = with pkgs; ["foot"];
+          "application/pdf" = with pkgs; ["qpdfview.desktop"];
+          "x-scheme-handler/file" = with pkgs; ["foot.desktop"];
         };
       };
     };